Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helm: hide evil cursor in minibuffer #732

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

taquangtrung
Copy link

Brief summary of what the package does

Hi,

This PR enables hiding cursor in minibuffer when a Helm session is active.

I fixed the issue that was previously mentioned in #63, but it wasn't fixed until now.

Can you consider merging?

Thanks!

Checklist

Assume you're working on mpc mode:

  • byte-compiles cleanly
  • M-x checkdoc is happy. Don't manually write (provide 'evil-collection-mpc), M-x checkdoc can do it automatically for you
  • define evil-collection-mpc-setup with defun
  • define evil-collection-mpc-mode-maps with defconst
  • All functions should start with evil-collection-mpc-

@taquangtrung taquangtrung mentioned this pull request May 23, 2023
modes/helm/evil-collection-helm.el Outdated Show resolved Hide resolved
@condy0919
Copy link
Collaborator

Eager macro-expansion failure: (wrong-number-of-arguments (2 . 2) 4)
Requiring evil-integration. Set evil-want-integration to t to remove this message.

See https://github.com/emacs-evil/evil-collection/issues/60 for more details.

In toplevel form:
modes/helm/evil-collection-helm.el:69:1:Error: Wrong number of arguments: (2 . 2), 8
make: *** [Makefile:11: compile] Error 1

Emacs 26.3 throws an error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants