Feature: Add (opt-in) support for cookies for treaty client #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
My app uses JWT auth that's stored in http-only cookies, so this would allow me to write Eden tests! This is just what Eden is missing. |
|
Hey @SaltyAom would you be willing to merge this PR? I didn't hear anything from you, so at this point I'm not sure if it's worth updating this branch. Let me know 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Oftentimes APIs persist session info in cookies, so when using eden treaty as a server-side test client (or in any other browser-less environment) it is really useful to be able to rely on treaty to manage cookies like a browser would.
I made this an optional feature, so by default the behavior is not changed.
I built this feature on top of tough-cookie which seems to be a not-uncommon way of adding cookie support to API clients. For example, a similar implementation can be found in Bruno (Postman/Insomnia alternative).