Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use bool instead of np.bool alias in generic kubeflow pipeline example #120

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lugi0
Copy link

@lugi0 lugi0 commented May 9, 2023

What changes were proposed in this pull request?

The np.bool alias was deprecated in Numpy 1.20 (https://numpy.org/doc/1.20/release/1.20.0-notes.html?highlight=numpy%20bool#using-the-aliases-of-builtin-types-like-np-int-is-deprecated) and completely breaks in Numpy 1.24. Using bool is equivalent to using np.bool.

How was this pull request tested?

Ran as a kubeflow pipeline, both before the change (failing) and after (passing).

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant