Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2186 Expression Builder: Operation symbols and add field buttons cannot add at the beginning of expression #2187

Merged
merged 6 commits into from
Oct 9, 2024

Conversation

mikieyx
Copy link
Contributor

@mikieyx mikieyx commented Sep 26, 2024

Fixes: #2186

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

Signed-off-by: Michael Pavlik <[email protected]>
Copy link
Contributor

@srikant-ch5 srikant-ch5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@@ -38,7 +38,7 @@ export default class ExpressionBuilder extends React.Component {
const value = (typeof newValue === "string") ? newValue : newValue.toString();
const somethingSelected = this.getCodemirrorState()?.selection.ranges.some((r) => !r.empty);
let cursor = this.getCodemirrorState()?.selection.main.head;
if (cursor === 0 && !somethingSelected) { // TODO: Doesn't work when I explicitly set the cursor to 0
if (isNaN(cursor) && !somethingSelected) { // TODO: Doesn't work when I explicitly set the cursor to 0
Copy link
Member

@matthoward366 matthoward366 Oct 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the TODO be removed? Also, is there a case where cursor === 0? Wonder if this should (isNaN(cursor) || cursor === 0) ...

Copy link
Contributor Author

@mikieyx mikieyx Oct 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll look into it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I switch the condition to (isNan(cursor) || cursor === 0) , the bug is still present. I'm not to sure about the comment, I can remove if need be.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should remove it since I don't know why it would be needed anymore.

@matthoward366 matthoward366 merged commit 5640aa3 into elyra-ai:main Oct 9, 2024
3 checks passed
@mikieyx mikieyx deleted the expression-builder-beginning branch October 9, 2024 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expression Builder: Operation symbols and add field buttons cannot add at the beginning of expression
3 participants