-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#2186 Expression Builder: Operation symbols and add field buttons cannot add at the beginning of expression #2187
#2186 Expression Builder: Operation symbols and add field buttons cannot add at the beginning of expression #2187
Conversation
Signed-off-by: Michael Pavlik <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@@ -38,7 +38,7 @@ export default class ExpressionBuilder extends React.Component { | |||
const value = (typeof newValue === "string") ? newValue : newValue.toString(); | |||
const somethingSelected = this.getCodemirrorState()?.selection.ranges.some((r) => !r.empty); | |||
let cursor = this.getCodemirrorState()?.selection.main.head; | |||
if (cursor === 0 && !somethingSelected) { // TODO: Doesn't work when I explicitly set the cursor to 0 | |||
if (isNaN(cursor) && !somethingSelected) { // TODO: Doesn't work when I explicitly set the cursor to 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the TODO
be removed? Also, is there a case where cursor === 0
? Wonder if this should (isNaN(cursor) || cursor === 0) ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll look into it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I switch the condition to (isNan(cursor) || cursor === 0)
, the bug is still present. I'm not to sure about the comment, I can remove if need be.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should remove it since I don't know why it would be needed anymore.
Signed-off-by: Michael Pavlik <[email protected]>
…vas into expression-builder-beginning
Fixes: #2186
Developer's Certificate of Origin 1.1