Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#2122 Expression builder - After expression validation, chars need to be entered twice to reflect #2123

Merged
merged 14 commits into from
Oct 14, 2024
Merged

#2122 Expression builder - After expression validation, chars need to be entered twice to reflect #2123

merged 14 commits into from
Oct 14, 2024

Conversation

mikieyx
Copy link
Contributor

@mikieyx mikieyx commented Aug 27, 2024

Fixes: #2122

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

Fixed expression char bug
a1410a5 
Signed-off-by: Michael Pavlik <[email protected]>
@mikieyx
Copy link
Contributor Author

mikieyx commented Aug 27, 2024

Waiting for #2118 to merge, then I can use the updated utility files to create a unit test for the fix.

@mikieyx
Copy link
Contributor Author

mikieyx commented Sep 25, 2024

Cannot add a unit test case that tests that the cursor position is in the right spot. I believe to find the cursor position, I would need to access an instance of expression which RTL is unable to do.

@srikant-ch5
Copy link
Contributor

Hi @mikieyx the condition which you have removed was added to resolve below issue. Could you please verify whether it is working fine ?
#2066

@veenas1
Copy link
Contributor

veenas1 commented Sep 27, 2024 •
edited
Loading

Hi @mikieyx the condition which you have removed was added to resolve below issue. Could you please verify whether it is working fine ? #2066

@mikieyx If we remove those lines, the below scenario will not be working I guess, even after saving it from tearsheet.
Can you please check?

expression-editor.mov

veenas1
veenas1 suggested changes Sep 30, 2024
View reviewed changes
Copy link
Contributor

@veenas1 veenas1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please check the scenario mentioned in above comment

@mikieyx
Copy link
Contributor Author

mikieyx commented Sep 30, 2024

The scenario doesn't work with my changes. I'll make some changes so the above scenario works while also eliminating the bug.

@mikieyx mikieyx requested a review from veenas1 October 3, 2024 16:23
@veenas1
Copy link
Contributor

veenas1 commented Oct 5, 2024

LGTM, except one scenario: Currently once the expression is edited from the editor, on closing, it is reflected in the flyout even without clicking Save. But with these changes, it reflects only on saving.
@matthoward366 Is it fine?

expr-edit.mov

@matthoward366
Copy link
Member

That is the correct behavior. We should only be saving when the user clicks Ok. I found 1 odd behavior. If I click cancel and try to reopen the editor I have to click the button twice. This didn't happen before.

@mikieyx can you see why this regressed?

@mikieyx
Copy link
Contributor Author

mikieyx commented Oct 7, 2024

That is the correct behavior. We should only be saving when the user clicks Ok. I found 1 odd behavior. If I click cancel and try to reopen the editor I have to click the button twice. This didn't happen before.

@mikieyx can you see why this regressed?

Hey Matt, I'm not seeing that issue on my end. I'm opening up the editor, clicking cancel, and then clicking the calculator icon once, and it is opening.

@matthoward366
Copy link
Member

Can you try entering text, then clicking cancel?

@mikieyx
Copy link
Contributor Author

mikieyx commented Oct 7, 2024

Can you try entering text, then clicking cancel?

I tried that and I'm seeing your issue. After clicking the cancel, the cursor is still in the editor. You have to click twice, one to unfocus the cursor and then one to click on the expression builder icon. I'll look into it.

matthoward366
matthoward366 approved these changes Oct 14, 2024
View reviewed changes
Copy link
Member

@matthoward366 matthoward366 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@matthoward366 matthoward366 merged commit 9ed6d70 into elyra-ai:main Oct 14, 2024
3 checks passed
@veenas1
Copy link
Contributor

veenas1 commented Oct 24, 2024

I tried that and I'm seeing your issue. After clicking the cancel, the cursor is still in the editor. You have to click twice, one to unfocus the cursor and then one to click on the expression builder icon. I'll look into it.

Hi @mikieyx @matthoward366 I saw similar behavior after editing in the flyout itself. Need to click the icon twice to open the editor modal.

expressionBuilder-flyout.mov

@matthoward366
Copy link
Member

@veenas1 can you create a new issue for this?

@veenas1
Copy link
Contributor

veenas1 commented Oct 24, 2024

Expression Builder: After editing in flyout,user needs to click icon twice to open Editor #3897

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthoward366 matthoward366 matthoward366 approved these changes

@srikant-ch5 srikant-ch5 Awaiting requested review from srikant-ch5

@veenas1 veenas1 Awaiting requested review from veenas1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expression builder - After expression validation, chars need to be entered twice to reflect
4 participants
@mikieyx @srikant-ch5 @veenas1 @matthoward366