Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2122 Expression builder - After expression validation, chars need to be entered twice to reflect #2123

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mikieyx
Copy link
Contributor

@mikieyx mikieyx commented Aug 27, 2024

Fixes: #2122

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

Signed-off-by: Michael Pavlik <[email protected]>
@mikieyx
Copy link
Contributor Author

mikieyx commented Aug 27, 2024

Waiting for #2118 to merge, then I can use the updated utility files to create a unit test for the fix.

@mikieyx
Copy link
Contributor Author

mikieyx commented Sep 25, 2024

Cannot add a unit test case that tests that the cursor position is in the right spot. I believe to find the cursor position, I would need to access an instance of expression which RTL is unable to do.

@srikant-ch5
Copy link
Contributor

Hi @mikieyx the condition which you have removed was added to resolve below issue. Could you please verify whether it is working fine ?
#2066

@veenas1
Copy link
Contributor

veenas1 commented Sep 27, 2024

Hi @mikieyx the condition which you have removed was added to resolve below issue. Could you please verify whether it is working fine ? #2066

@mikieyx If we remove those lines, the below scenario will not be working I guess, even after saving it from tearsheet.
Can you please check?

expression-editor.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expression builder - After expression validation, chars need to be entered twice to reflect
3 participants