Answers for Take Home Test

html-css/WhatWouldYouChange/test.html

@@ -19,6 +19,17 @@
 * The content itself
 
 Bonus point for the correct use of the word "semantic" in an answer.
+
++ bold might benefit from a span tag to not conflict with CSS
++ ID is caps
++ indentation is not clear - what elements contain other elements
++ <br> might benefit from a list
++ <p> might actually be a <ul>
++ <p> closing tag bad
++ redSection not very descriptive id
++ might benefit from some classes
++ information might need to be contained in a form
++ paragraphs are for reading not for listing
 -->
 
 <div ID=redSection>
@@ -29,4 +40,4 @@
 </div>
 
 </body>
-</html>
+</html>

java/src/main/java/com/elsevier/education/Exercise1.java

@@ -7,14 +7,14 @@
 TODO: Make this class immutable.
 
 */
-public class Exercise1 {
+public final class Exercise1 {
 
 	public static class Person {
-		
+
 		private Set<String> phoneNumbers;
 		private String firstName;
 		private String lastName;
-		
+
 		public Person() {
 		}
 
@@ -24,19 +24,19 @@ public Set<String> getPhoneNumbers() {
 		public void setPhoneNumbers(Set<String> newPhoneNumbers) {
 			phoneNumbers = newPhoneNumbers;
 		}
-		
+
 		public String getFirstName() {
 			return firstName;
 		}
 		public void setFirstName(String newName) {
 			firstName = newName;
 		}
-		
+
 		public String getLastName() {
 			return lastName;
 		}
 		public void setLastName(String newName) {
 			lastName = newName;
 		}
 	}
-}
+}

java/src/main/java/com/elsevier/education/Exercise4.java

@@ -8,20 +8,20 @@
 public class Exercise4 {
 
 	public static class Counter {
-		
+
 		private int count = 0;
-		
-		public int increment() {
+
+		public synchronized int increment() {
 			return ++count;
 		}
-		
-		public int getCount() {
+
+		public synchronized int getCount() {
 			return count;
 		}
-		
-		public void resetCount() {
+
+		public synchronized void resetCount() {
 			count = 0;
 		}
 
 	}
-}
+}

javascript/WhatWouldYouChange/test.html

@@ -12,6 +12,17 @@
   This code appears to work. Nonetheless note up to 10 things that look bad to you, including a brief note as to why.
 
   Please consider both minor syntactical issues with the code as it stands, and how the code is structured overall.
+
+  + ES6 should be used
+  + if else statement is hard to read with too many line breaks
+  + reqFlds variable is defined in two different ways - more consistancy is better
+  + return false should be on the same line
+  + conditional statements should have no line break
+  + return statement could just change the submitButtonActive variable
+  + reqFlds seems to not be declared properly
+  + might need document ready for loading purposes
+  + inconsistant semicolons
+  + console logging a string and the funciton?
    */
 
   var submitButtonActive = false
@@ -51,4 +62,4 @@
 <p><input id="submitButton" type="submit" value="submit" /></p>
 
 </body>
-</html>
+</html>