Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix serialization context #156

Merged
merged 12 commits into from
May 28, 2024
Merged

Conversation

elringus
Copy link
Owner

@elringus elringus commented May 28, 2024

JSON serializer will now use type of the seriailzed properties or parameters instead of type of the value instances.

This fixes error when attempting to serialize properties or parameters under collections interfaces, which are assigned via collection expressions.

This also improves #138, making supported array types under tasks transfer without serialization; though an extra allocation is still required (compared to the scenario when .NET would natively support deeper nesting for marshaling hints), hence the issue is still tracked.

Copy link

codecov bot commented May 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (3817bed) to head (bc20566).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #156   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           45        47    +2     
  Lines         1653      1642   -11     
  Branches       296       293    -3     
=========================================
- Hits          1653      1642   -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@elringus elringus merged commit df39df3 into main May 28, 2024
8 checks passed
@elringus elringus deleted the fix/collection-expressions-serialization branch May 28, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant