Fix/gradle run, SpringBootNewProject version pick #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
Thank you for this project and for the awesome tutorial on YouTube about setup NVim for Java development! Was looking for something similar for quite a long time.
This PR contains some tiny changes:
Fix for Gradle
Lua empty string is considered as
True, so Gradle branch in theget_run_commandwas never reachable.Also I'd like to suggest to use wrappers for both Maven and Gradle - I assume most SpringBoot project will have them.
Fix for
SpringBootNewProject.get_boot_versionCurrently version of the SpringBoot is hardcoded (3.3.1.RELEASE) and is not available on the site. I suggest to just pick one from the available values to avoid error in case when click Enter for all default values.
README update
To use
:SpringBootNewProjectCLI tool needs to be installed, and it was not mentioned in the README. I thought that it would be nice to mention that for new users.I'll be glad if some of those changes might be useful.