Fix tests #20
Open
Fix tests #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this commit, tests run again (I believe they last run with elm 0.18.0). I have used the same approach as elm/core#1017 to get these tests running.
|
See CI running on my fork: https://travis-ci.com/harrysarson/json |
|
May I bump :) |
|
Bump 🕺 bump 🕺 |
|
🐎 |
|
Thank you for making this. I am preparing a PR to fix this and it will be useful. |
marc136
pushed a commit
to elm-janitor/json
that referenced
this pull request
Nov 25, 2023
fix tests With this commit, tests run again (I believe they last run with elm 0.18.0). I have used the same approach as elm/core#1017 to get these tests running.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this commit, tests run again (I believe they last ran with
elm 0.18.0). I have used the same approach as
elm/core#1017 to get these tests running.
I have also added integration with travis CI.
cc: @jerith666 and @Skinney re similarity with elm/core