Avoid duplicate toCode calls in multiple Char.is... functions#1146
Open
jfmengels wants to merge 1 commit intoelm:masterfrom
Open
Avoid duplicate toCode calls in multiple Char.is... functions#1146jfmengels wants to merge 1 commit intoelm:masterfrom
jfmengels wants to merge 1 commit intoelm:masterfrom
Conversation
This reduces the number of calls to `toCode char`. For instance, in the isAlphaNum function, the char argument would be converted to a char up to 3 times (once in isLower, isUpper and isDigit). This makes it so that the conversion is done at most once, improving performance of the functions.
|
Thanks for suggesting these code changes. To set expectations:
Finally, please be patient with the core team. They are trying their best with limited resources. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reduces the number of calls to
toCode char. For instance, in the isAlphaNum function, the char argument would be converted to a char up to 3 times (once in isLower, isUpper and isDigit).This makes it so that the conversion is done at most once, improving performance of the functions.
@lue-bird discovered this as an optimization for parsers (as part of stil4m/elm-syntax#237), where the
Char.isAlphaNumfunction is used to identify variables.Functions like
isUppernow make a function call to delegate to their dedicated helper. I don't know if it matters much (I assume a JIT compiler will optimize this) and we could duplicate the comparison logic in bothisUpperandisUpperCodeto avoid that, but I figured reducing duplication and therefore potential errors to be a reasonable default. I'mm happy to change this.