Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimal fix for issue #2241 #2330

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

changlinli
Copy link

This fixes #2241

Preliminary testing seems to indicate this isn't as bad of a slowdown as it may seem. For more details see Zokka-Dev/zokka-compiler#20

This is meant as a reference PR for other people working on the Elm compiler.

This fixes elm#2241

Preliminary testing seems to indicate this isn't as bad of a slowdown as
it may seem. For more details see Zokka-Dev/zokka-compiler#20

This is meant as a reference PR for other people working on the Elm
compiler.
Copy link

Thanks for suggesting these code changes. To set expectations:

  • Pull requests are reviewed in batches, so it can take some time to get a response.
  • Smaller pull requests are easier to review. To fix nine typos, nine specific issues will always go faster than one big one. Learn why here.
  • Reviewers may not know as much as you about certain situations, so add links to supporting evidence for important claims, especially regarding standards for CSS, HTTP, URI, etc.

Finally, please be patient with the core team. They are trying their best with limited resources.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

elm make hang then runaway memory usage from orphan process
1 participant