Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert hot-reloading regressions #1296

Merged
merged 2 commits into from
Mar 25, 2025
Merged

Revert hot-reloading regressions #1296

merged 2 commits into from
Mar 25, 2025
+46 −80

Conversation

elkowar
Copy link
Owner

@elkowar elkowar commented Mar 16, 2025

This PR reverts the commits that introduced regressions in the behavior of hot-reloading.

elkowar added 2 commits March 16, 2025 16:39
@elkowar
Revert "Force recreating windows on config change (#1284)"
Loading
Loading status checks…
c42bdbf 
This reverts commit 29fa158.
@elkowar
Revert "Avoid recreating windows when only duration changes (#1236)"

Verified

This commit was signed with the committer’s verified signature.
elkowar ElKowar
GPG key ID: 862BA3D7D7760F13
Verified
Learn about vigilant mode
Loading
Loading status checks…
1e1d907 
This reverts commit b6b7bc8.
This was referenced Mar 16, 2025
Open
Open
@gh0stzk gh0stzk mentioned this pull request Mar 24, 2025
Closed
@elkowar elkowar merged commit a9aa0f9 into master Mar 25, 2025
1 check passed
@elkowar elkowar deleted the revert-hot-reload-regression branch March 25, 2025 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@elkowar