Merged
Conversation
List of changes: - add Elixir 1.19.0 / OTP 28.0 to CI test matrix - fix flaky hackney max_body test - fix typing violation in AdapterCase - move format check (lint) to latest Elixir/OTP combination - rename httpc profile test to match *_test.exs pattern
kianmeng
commented
Mar 19, 2026
| method: :post, | ||
| url: "#{@http}/post", | ||
| body: String.duplicate("long response", 1000) | ||
| body: body |
Contributor
Author
There was a problem hiding this comment.
1) test get with `:max_body` option (Tesla.Adapter.HackneyTest)
test/tesla/adapter/hackney_test.exs:39
Assertion with < failed
code: assert byte_size(response.body) < 2000
left: 9089
right: 2000
stacktrace:
test/tesla/adapter/hackney_test.exs:48: (test)
kianmeng
commented
Mar 19, 2026
| mod -> {mod, []} | ||
| end | ||
|
|
||
| mod.call(env, Keyword.merge(opts, adapter_opts)) |
Contributor
Author
There was a problem hiding this comment.
warning: expected a module (an atom) when invoking call/2 in expression:
adapter_mod.call(env, opts)
where "adapter_mod" (context Tesla.AdapterCase) was given the type:
# type: {Tesla.Adapter.Httpc, non_empty_list({:profile, :test_profile})}
# from: test/tesla/adapter/httpc_test/profile_test.exs:5
adapter_mod
where "env" (context Tesla.AdapterCase) was given the type:
# type: dynamic()
# from: test/tesla/adapter/httpc_test/profile_test.exs:5
env
where "opts" (context Tesla.AdapterCase) was given the type:
# type: dynamic()
# from: test/tesla/adapter/httpc_test/profile_test.exs:5
opts
typing violation found at:
│
5 │ use Tesla.AdapterCase, adapter: {Tesla.Adapter.Httpc, profile: @profile}
│ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
│
└─ test/tesla/adapter/httpc_test/profile_test.exs:5: Tesla.Adapter.HttpcTest.Profile.call/2
warning: expected a module (an atom) when invoking call/2 in expression:
adapter_mod.call(env, opts)
where "adapter_mod" (context Tesla.AdapterCase) was given the type:
# type: {Tesla.Adapter.Finch, non_empty_list({:name, MyFinch})}
# from: test/tesla/adapter/finch_test.exs:6
adapter_mod
where "env" (context Tesla.AdapterCase) was given the type:
# type: dynamic()
# from: test/tesla/adapter/finch_test.exs:6
env
where "opts" (context Tesla.AdapterCase) was given the type:
# type: dynamic()
# from: test/tesla/adapter/finch_test.exs:6
opts
typing violation found at:
│
6 │ use Tesla.AdapterCase, adapter: {Tesla.Adapter.Finch, [name: @finch_name]}
│ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
│
└─ test/tesla/adapter/finch_test.exs:6: Tesla.Adapter.FinchTest.call/2
Member
|
@kianmeng as always, thank you so much. I wonder, do you know how to fix:
It keeps failing in CI 😭 |
Contributor
Author
@yordis https://github.com/myfloss/tesla/pull/1/checks 
Also, thanks for the prompt response and keeping this library well-maintained. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
List of changes: