Add helper functions for Google.Protobuf modules #354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nezteb
approved these changes
Nov 27, 2023
ddengler
approved these changes
May 23, 2024
btkostner
commented
Oct 28, 2024
v0idpwn
approved these changes
Nov 1, 2024
whatyouhide
reviewed
Nov 2, 2024
|
@btkostner, would you like to address Andrea's comments, or would you prefer for me to take this one over? Happy either way :) |
|
Go for it! I'm on a deadline for work right now so I doubt I'll have free time to work on this 👍 |
- Remove `to_time_unit/1` and `from_time_unit/2` - Fix type reference in documentation - Add better example
v0idpwn
changed the title
|
@v0idpwn do you think it would be possible to cut off a release? |
|
Hi, @yordis! I don't have the permission to make releases, so we need to ask @whatyouhide or @ericmj. For me, the current main seems okay to be released. I'm just a bit worried that #384 and #353 may make update not very smooth. |
|
384 adds a compile time dependency from protobuf definitions to transform module, which can make existing code have circular dependencies. Don't get me wrong, though, I think it's fine to be released :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces elixir-protobuf/google-protos#21. Should be merged after #353.