upgrading to ort 2.0.0-rc.2, onnxruntime 1.17.3 #28
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi
I had an issue getting the Ortex compiled in a Docker container, and then an issue running the tests on a Mac, which I thought might have been caused by downloading the Onnx runtime shared libraries.
So, I tried upgrading to the latest Rustler and Ortex. With these updates, I don't seem to need the libs copy workaround in lib/vortex/native.ex as now one lib is created. I have only tested this on Mac and Linux without Cuda.
The issue with not working on Mac was the Statically linking to CoreML bindings needing the link flag
"-C link-arg=-fapple-link-rtlib" according to the Ort docs.
The docker compile was a path issue with cargo, which I only figured out after updating the dependencies.