Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mijke jetten patch 2 #153

Merged
merged 16 commits into from
Nov 11, 2024
Merged

Mijke jetten patch 2 #153

merged 16 commits into from
Nov 11, 2024

Conversation

MijkeJetten
Copy link
Collaborator

Updated Why FAIR lesson plan (outcomes, activities, overview, prerequisites + cleaned up)

@MijkeJetten
Copy link
Collaborator Author

MijkeJetten commented Nov 8, 2024

Hi @martijnkersloot @bianchini88 hope my changes didn't break anything. Can you please check if all code is ok and both tables are ok? It's a branch before Martijn made the Jekyll changes

@martijnkersloot
Copy link
Collaborator

@MijkeJetten Thanks for the heads up :). I'll update your branch to follow the new structure!

Copy link
Collaborator

@bianchini88 bianchini88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments mostly style/spelling related.

@MijkeJetten
Copy link
Collaborator Author

@martijnkersloot @bianchini88 if we can deploy before Tuesday (as I will be giving the presentation then) that would be great

bianchini88 and others added 5 commits November 10, 2024 17:12
Fixing bug: removing ":"
Commenting lines that seem to be causing errors, probably containing non supported fields
: causing issues, trying escaping
Removing ":"
@bianchini88 bianchini88 self-requested a review November 10, 2024 16:37
@bianchini88
Copy link
Collaborator

@MijkeJetten @martijnkersloot I solved merging conflicts and addressed some other minor issues. I think it should be mergeable now. It requires the approval of somebody other than me.

@MijkeJetten
Copy link
Collaborator Author

@martijnkersloot @konradana @nrvanulzen please one of you approve, I can't

@bianchini88
Copy link
Collaborator

@MijkeJetten @martijnkersloot @konradana @nrvanulzen I have issues previewing the webpage locally. Does any of you manage to preview the page locally? Or do we merge the PR and take it from there?

@MijkeJetten
Copy link
Collaborator Author

MijkeJetten commented Nov 11, 2024

I didn't manage to preview it locally. Can we merge and take it from there? Or is that too tricky?

@bianchini88
Copy link
Collaborator

I didn't manage to preview it locally. Can we merge and take it from there? Or is that too tricky?

The only tricky bit is that the changes will go live, so if there is any issue anybody will see it,
which is probably not an issue at this early stage.

@MijkeJetten
Copy link
Collaborator Author

I don't think that is an issue now. @martijnkersloot agree? It would be great if we can fix it ASAP though haha, since I need to present tomorrow

@martijnkersloot
Copy link
Collaborator

Yep, I'll check it out on my own computer as I think that some things will not work yet. I'll ping you later today!

@bianchini88
Copy link
Collaborator

@martijnkersloot Can you share the Gemfile.lock and the Gemfile (if you have to edit it to make it work)?
I need to add something like gem "faraday", "< 1.0 to my Gemfile to make it work and have to use
gem install bundler -v 2.4.22. This approach does not crash, but things are not visualised properly...

@martijnkersloot martijnkersloot merged commit 139f0f6 into main Nov 11, 2024
2 checks passed
@martijnkersloot martijnkersloot deleted the MijkeJetten-patch-2 branch November 11, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants