-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mijke jetten patch 2 #153
Mijke jetten patch 2 #153
Conversation
Updated activities
Cleaned up
Updated activities
Hi @martijnkersloot @bianchini88 hope my changes didn't break anything. Can you please check if all code is ok and both tables are ok? It's a branch before Martijn made the Jekyll changes |
@MijkeJetten Thanks for the heads up :). I'll update your branch to follow the new structure! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor comments mostly style/spelling related.
Co-authored-by: Federico Bianchini <[email protected]>
Co-authored-by: Federico Bianchini <[email protected]>
Co-authored-by: Federico Bianchini <[email protected]>
@martijnkersloot @bianchini88 if we can deploy before Tuesday (as I will be giving the presentation then) that would be great |
Fixing bug: removing ":"
Commenting lines that seem to be causing errors, probably containing non supported fields
: causing issues, trying escaping
Removing ":"
@MijkeJetten @martijnkersloot I solved merging conflicts and addressed some other minor issues. I think it should be mergeable now. It requires the approval of somebody other than me. |
@martijnkersloot @konradana @nrvanulzen please one of you approve, I can't |
@MijkeJetten @martijnkersloot @konradana @nrvanulzen I have issues previewing the webpage locally. Does any of you manage to preview the page locally? Or do we merge the PR and take it from there? |
I didn't manage to preview it locally. Can we merge and take it from there? Or is that too tricky? |
The only tricky bit is that the changes will go live, so if there is any issue anybody will see it, |
I don't think that is an issue now. @martijnkersloot agree? It would be great if we can fix it ASAP though haha, since I need to present tomorrow |
Yep, I'll check it out on my own computer as I think that some things will not work yet. I'll ping you later today! |
@martijnkersloot Can you share the Gemfile.lock and the Gemfile (if you have to edit it to make it work)? |
Updated Why FAIR lesson plan (outcomes, activities, overview, prerequisites + cleaned up)