Skip to content

Delete errors - #67

Closed
pmareke wants to merge 10 commits into
elixir-error-tracker:mainfrom
pmareke:main
Closed

pmareke wants to merge 10 commits into
elixir-error-tracker:mainfrom
pmareke:main

Conversation

@pmareke

@pmareke pmareke commented Aug 24, 2024 •

Copy link
Copy Markdown
Contributor

This PR adds the possibility to delete a given error and emmits an event when the error is deleted.

Delete in the Dashboard view
image

Delete in the show view:
image

@crbelaus

Copy link
Copy Markdown
Contributor

I've been reflecting on this for some time and, while the implementation of this PR is not bad, I think it is not solving the right problem in the right way.

The problem that we want to solve is twofold. On the one hand we want to remove old errors so they don't show in the dashboard or take space in the database. On the other hand we want to avoid recording errors based on some client-provided criteria.

Removing an error is not particularly useful as new occurrences will create that same error again. Furthermore, depending on the number of occurrences that the error has, the Repo.delete operation may take a long time due to cascade deletions.

We are working on an error pruner that will remove old, resolved errors safely. But that requires careful consideration and measurement of query plans both in Postgres and SQLite.

So, thanks again for this work, but this is not a desirable feature at the moment.

@crbelaus crbelaus closed this Aug 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants