Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve docs regarding LiveView scope #115

Merged
merged 1 commit into from
Dec 9, 2024
Merged

Improve docs regarding LiveView scope #115

merged 1 commit into from
Dec 9, 2024

Conversation

odarriba
Copy link
Contributor

@odarriba odarriba commented Dec 2, 2024

Closes #114

@odarriba odarriba requested a review from crbelaus December 2, 2024 20:50
@odarriba odarriba self-assigned this Dec 2, 2024
crbelaus
crbelaus approved these changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

@crbelaus crbelaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Initially I assumed this would be the implicitly understood, but it is much better to have it explicitly stated in the docs.

@odarriba odarriba merged commit 9b09bb8 into main Dec 9, 2024
3 checks passed
@odarriba odarriba deleted the improve-docs branch December 9, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crbelaus crbelaus crbelaus approved these changes

Assignees

@odarriba odarriba

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

/errors page reloads infinitely
2 participants
@odarriba @crbelaus