Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter context only when tracking errors #100

Merged
merged 4 commits into from
Oct 18, 2024
Merged

Filter context only when tracking errors #100

merged 4 commits into from
Oct 18, 2024

Conversation

crbelaus
Copy link
Contributor

@crbelaus crbelaus commented Oct 12, 2024 •
edited
Loading

Just a few additions to #94:

  • We don't need to filter context when not tracking errors
  • Mention how to filter context in the Getting Started guide

@crbelaus crbelaus requested a review from odarriba October 12, 2024 08:35
@crbelaus crbelaus marked this pull request as ready for review October 12, 2024 08:35
odarriba
odarriba reviewed Oct 16, 2024
View reviewed changes
Copy link
Contributor

@odarriba odarriba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small typo, aside from that is perfect 👍 🚀

guides/Getting Started.md Outdated Show resolved Hide resolved
@crbelaus @odarriba
Update guides/Getting Started.md
68c00bc 
Co-authored-by: Óscar de Arriba <[email protected]>
@crbelaus crbelaus merged commit e00040f into main Oct 18, 2024
3 checks passed
@crbelaus crbelaus deleted the delay-context-filtering branch October 18, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odarriba odarriba odarriba left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@crbelaus @odarriba