Fix Changeset.changed?/2 for assocs
#4544
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setting assoc to nil actually errors as it is not handled in changed?/2, while settin existing assoc to belongs_to assoc returns changed?/2 as false.
It now returns true whenever `fetch_change? != :error`. Previously, it returned
false when assoc was set to existing struct (as `changeset.changes == %{}`) and
errored when set to nil (due to `nil.changes != %{}` check in `relation_changed?`.
Fixes elixir-ecto#4543.
jesenko
force-pushed
the
changed_for_assocs
branch
from
e74f9ee
to
2fce190
Compare
|
We should fix it to handle |
|
Hi @josevalim thank you for looking into this. Note that handling |
|
Yes, we need to check more cases. And potentialy make it recursive. But simply checking if the field is set is not enough. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It now returns true whenever
fetch_change? != :error. Previously, it returnedfalse when assoc was set to existing struct (as
changeset.changes == %{}) anderrored when set to nil (due to
nil.changes != %{}check inrelation_changed?.Fixes #4543.