Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix inspecting dynamc with interpolated named bindings #4541

Merged
merged 2 commits into from
Nov 3, 2024
Merged

fix inspecting dynamc with interpolated named bindings #4541

merged 2 commits into from
Nov 3, 2024

Conversation

greg-rychlewski
Copy link
Member

@greg-rychlewski greg-rychlewski commented Nov 2, 2024 •
edited
Loading

Closes #4537

@greg-rychlewski
Copy link
Member Author

I did it two ways....the first commit keeps the pin in the inspect and the second one doesn't. I think the second is nicer but can change it back if you prefer the first.

josevalim
josevalim approved these changes Nov 3, 2024
View reviewed changes
Copy link
Member

@josevalim josevalim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't keep the pin i think because we don't keep it for regular queries.

@greg-rychlewski greg-rychlewski merged commit d47bc2c into elixir-ecto:master Nov 3, 2024
6 checks passed
@greg-rychlewski greg-rychlewski deleted the interpolated_binding_dynamic_inspect branch November 3, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josevalim josevalim josevalim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inspect.Error when bind name is pinned
2 participants
@greg-rychlewski @josevalim