Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support associations with composite foreign keys #3638

Open
wants to merge 34 commits into
base: master
Choose a base branch
from
Open

Support associations with composite foreign keys #3638

wants to merge 34 commits into from

Commits on May 16, 2023

  1. Support associations on composite foreign keys

    Leo B committed May 16, 2023
    Configuration menu
    Copy the full SHA
    4a0264d View commit details
    Browse the repository at this point in the history

  2. Update lib/ecto/association.ex 

    Co-authored-by: José Valim <[email protected]>
    @soundmonster @josevalim
    2 people authored and Leo B committed May 16, 2023
    Configuration menu
    Copy the full SHA
    fefee0c View commit details
    Browse the repository at this point in the history

  3. Implement suggestions from PR review

    Leo B committed May 16, 2023
    Configuration menu
    Copy the full SHA
    f29c121 View commit details
    Browse the repository at this point in the history

  4. Add test for many_to_many, clean up

    Leo B committed May 16, 2023
    Configuration menu
    Copy the full SHA
    ce380a8 View commit details
    Browse the repository at this point in the history

  5. Use exact binding positions for joins

    Leo B committed May 16, 2023
    Configuration menu
    Copy the full SHA
    1d68ad0 View commit details
    Browse the repository at this point in the history

  6. Stabilize test by specifying order

    Leo B committed May 16, 2023
    Configuration menu
    Copy the full SHA
    e2dd4a5 View commit details
    Browse the repository at this point in the history

  7. Move away from dynamic() joins for one and two PK columns

    Leo B committed May 16, 2023
    Configuration menu
    Copy the full SHA
    1ed34b4 View commit details
    Browse the repository at this point in the history

  8. Remove dynamic() from joins completely

    Leo B committed May 16, 2023
    Configuration menu
    Copy the full SHA
    ce651f3 View commit details
    Browse the repository at this point in the history

  9. Remove dynamic() from almost all cases

    Leo B committed May 16, 2023
    Configuration menu
    Copy the full SHA
    b21a4e7 View commit details
    Browse the repository at this point in the history

  10. Remove all uses of dynamic for association queries

    Leo B committed May 16, 2023
    Configuration menu
    Copy the full SHA
    9e18f75 View commit details
    Browse the repository at this point in the history

  11. Fix post-rebase issues, all unit tests but 1 pass now

    Leo B committed May 16, 2023
    Configuration menu
    Copy the full SHA
    ca19a2a View commit details
    Browse the repository at this point in the history

  12. Wip fixing tests

    Leo B committed May 16, 2023
    Configuration menu
    Copy the full SHA
    02146bd View commit details
    Browse the repository at this point in the history

  13. Tweak order of ON clauses

    Leo B committed May 16, 2023
    Configuration menu
    Copy the full SHA
    2b5f584 View commit details
    Browse the repository at this point in the history

  14. All tests are green

    Leo B committed May 16, 2023
    Configuration menu
    Copy the full SHA
    fb2afcc View commit details
    Browse the repository at this point in the history

  15. Fix compiler warning, remove 'debugger' module

    Leo B committed May 16, 2023
    Configuration menu
    Copy the full SHA
    dc652ac View commit details
    Browse the repository at this point in the history

  16. Start adding docs

    Leo B committed May 16, 2023
    Configuration menu
    Copy the full SHA
    b8665ce View commit details
    Browse the repository at this point in the history

  17. Auto-derive assoc keys for has_*

    Leo B committed May 16, 2023
    Configuration menu
    Copy the full SHA
    0333ffc View commit details
    Browse the repository at this point in the history

  18. Update docs

    Leo B committed May 16, 2023
    Configuration menu
    Copy the full SHA
    658060d View commit details
    Browse the repository at this point in the history

  19. wip

    Leo B committed May 16, 2023
    Configuration menu
    Copy the full SHA
    d02709c View commit details
    Browse the repository at this point in the history

  20. Wip but at least it compiles 😅

    Leo B committed May 16, 2023
    Configuration menu
    Copy the full SHA
    66d5299 View commit details
    Browse the repository at this point in the history

  21. Fix schema tests

    Leo B committed May 16, 2023
    Configuration menu
    Copy the full SHA
    13c6f8e View commit details
    Browse the repository at this point in the history

  22. Undo autoformatter changes

    Leo B committed May 16, 2023
    Configuration menu
    Copy the full SHA
    527354d View commit details
    Browse the repository at this point in the history

  23. Fix repo tests

    Leo B committed May 16, 2023
    Configuration menu
    Copy the full SHA
    edb05bd View commit details
    Browse the repository at this point in the history

  24. Fix Ecto.assoc

    Leo B committed May 16, 2023
    Configuration menu
    Copy the full SHA
    f3ae0cd View commit details
    Browse the repository at this point in the history

  25. Fix all tests 🎉

    Leo B committed May 16, 2023
    Configuration menu
    Copy the full SHA
    e82f12d View commit details
    Browse the repository at this point in the history

  26. Fix integration tests

    Leo B committed May 16, 2023
    Configuration menu
    Copy the full SHA
    65a6331 View commit details
    Browse the repository at this point in the history

  27. Remove superfluous guard

    Leo B committed May 16, 2023
    Configuration menu
    Copy the full SHA
    a6588ac View commit details
    Browse the repository at this point in the history

  28. Fix typo

    Leo B committed May 16, 2023
    Configuration menu
    Copy the full SHA
    458e704 View commit details
    Browse the repository at this point in the history

  29. Simplify chain_through

    Leo B committed May 16, 2023
    Configuration menu
    Copy the full SHA
    d887cb3 View commit details
    Browse the repository at this point in the history

  30. Improve docs, remove checked TODO

    Leo B committed May 16, 2023
    Configuration menu
    Copy the full SHA
    304df11 View commit details
    Browse the repository at this point in the history

  31. Add tests for updating a has_one/has_many

    Leo B committed May 16, 2023
    Configuration menu
    Copy the full SHA
    f73f511 View commit details
    Browse the repository at this point in the history

  32. Improve test clarity

    Leo B committed May 16, 2023
    Configuration menu
    Copy the full SHA
    8551091 View commit details
    Browse the repository at this point in the history

  33. Fix post-compile assoc validation

    Leo B committed May 16, 2023
    Configuration menu
    Copy the full SHA
    1573854 View commit details
    Browse the repository at this point in the history

  34. Fix warnings in preloader tests by adding explicit on-clauses

    Leo B committed May 16, 2023
    Configuration menu
    Copy the full SHA
    d42688c View commit details
    Browse the repository at this point in the history