Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ci): add PR evaluation #124

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

feat(ci): add PR evaluation #124

wants to merge 1 commit into from

Conversation

JaeAeich
Copy link

@JaeAeich JaeAeich commented Mar 5, 2024

Description

This PR add PR evaluation, lint, format and git message checks into the CI pipeline.

Reviewer note

Eventhough lint-staged formats the files pre-commit, it can be skipped by editting the package.json and not staging package.json, hence it makes sense to check format of the files in CI.

Copy link

vercel bot commented Mar 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
landing-page ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 5, 2024 10:40am

@uniqueg
Copy link
Member

uniqueg commented Mar 5, 2024

Interesting that Vercel doesn't fail here... Anyway, great effort, @JaeAeich. Let's see what @git-anurag-hub says

@JaeAeich
Copy link
Author

JaeAeich commented Mar 5, 2024

@uniqueg yeah the issue seems to be with how dependencies insode monorepo are build in CI.

IDK why this PR is not being evaluated though. Since I pushed the yaml it should evaluate this one as well 🤷‍♂️

@JaeAeich
Copy link
Author

JaeAeich commented Mar 5, 2024

@git-anurag-hub How are we going to use elixir-eslint-config? this already has a huge list of rules, migrating that would mean alot of code changes, but maybe let me try if its otherwise.

@uniqueg
Copy link
Member

uniqueg commented Mar 6, 2024

Maybe linter changes are a lot all at once, but usually they are just repetitive work, nothing hard.

What you could do is address everything but the linting and open another issue for that. Maybe someone else feels like taking it up, e.g., as a warmup to get to know the codebase :) Anyway, it's not urgent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants