-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ci): add PR evaluation #124
base: dev
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Interesting that Vercel doesn't fail here... Anyway, great effort, @JaeAeich. Let's see what @git-anurag-hub says |
@uniqueg yeah the issue seems to be with how dependencies insode monorepo are build in CI. IDK why this PR is not being evaluated though. Since I pushed the yaml it should evaluate this one as well 🤷♂️ |
@git-anurag-hub How are we going to use |
Maybe linter changes are a lot all at once, but usually they are just repetitive work, nothing hard. What you could do is address everything but the linting and open another issue for that. Maybe someone else feels like taking it up, e.g., as a warmup to get to know the codebase :) Anyway, it's not urgent |
52d26e1
to
b2e120b
Compare
Description
This PR add PR evaluation, lint, format and git message checks into the CI pipeline.
Reviewer note
Eventhough
lint-staged
formats the files pre-commit, it can be skipped by editting the package.json and not staging package.json, hence it makes sense to check format of the files in CI.