You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@ivarvong Thank you for your response.
The feature you added is a good step in the right direction.
The feature I'm missing from it is that a command must have a module that contains it's logic and name.
In my system these commands can be dynamic per sandbox (including the command's name), right now I cannot imagine how I should implement it with the new commands feature. It would help if we could implement additional pattern to register a command {Module, Opts}. This will allow to use a module that knows how to locate and execute the relevant logic and would allow the library to provide alias functionality without requiring the module to have stattic aliases hard-coded. (the Opts option will be passed to calls of Module.names and Module.execute)
Looking forward to your response
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the ability to add a custom builtin registery
Changes
JushBash.new/1:custom_builtin_registeryJustBash.Commands.Registryget's theJustBashinstance as first argument.JustBash.Interpreter.Executor.execute_builtin/4to execute a function-defined builtinsRelated Issues
Non.
Type of Change
Testing
Describe how this was tested:
Checklist
mix formatmix credoand addressed any issues