-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
documentation publish failing #255
documentation publish failing #255
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is the right solution. If you run a build locally and look at the dist
dir, the application is now under a /browser
subdir. We will need to append /browser
to the paths in build-docs job.
I think the cp
command is still needed. The Angular 17 documentation for deploying to GitHub pages still has this step:
- When the build is complete, make a copy of docs/index.html and name it docs/404.html.
I have tested it as you suggested, It's working, But now how should I have to publish the documentation as it runs on the new release. Should I have to release a new version for that? |
No need to release a new version. Just deploy it from this branch like you did before and verify that the documentation site is working. |
|
Overview
How it was tested
Checklist