Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RT-1384 (charts-on-fhir) Customize tooltip title #254

Merged
merged 4 commits into from
Jun 24, 2024

Conversation

vdeshkar
Copy link
Contributor

@vdeshkar vdeshkar commented Jun 21, 2024

Overview

When creating a custom mapper, we can customize the tooltip title to use something other than the y-value for category scales.

How it was tested

I ran the showcase app and checked the graphs by adding a tooltipTitle in its mappers.

Checklist

  • The title contains a short meaningful summary
  • I have added a link to this PR in the Jira issue
  • I have described how this was tested
  • I have included screen shots for changes that affect the user interface
  • I have updated unit tests
  • I have run unit tests locally
  • I have updated documentation (including README)
    tooltipTitle

semicolin
semicolin previously approved these changes Jun 21, 2024
yashpmohod
yashpmohod previously approved these changes Jun 21, 2024
@yashpmohod
Copy link
Contributor

hi @vdeshkar one thing from my side, do we need a minor version release for this?

@vdeshkar
Copy link
Contributor Author

vdeshkar commented Jun 21, 2024

hi @vdeshkar one thing from my side, do we need a minor version release for this?

Yes @yashpmohod, I'll update the version

@vdeshkar vdeshkar dismissed stale reviews from yashpmohod and semicolin via 65291f9 June 21, 2024 15:14
@semicolin
Copy link
Collaborator

Since we have 2 approved PRs we could release them both in the same version (4.0). If they both change the version number we need to resolve the conflict.

semicolin
semicolin previously approved these changes Jun 21, 2024
Copy link

@vdeshkar vdeshkar merged commit f92d202 into main Jun 24, 2024
5 checks passed
@vdeshkar vdeshkar deleted the RT-1384-charts-on-fhir-customize-tooltip-title branch June 24, 2024 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants