Buttons: Rewrite

[danirabbit]

Try to rewrite with fewer overrides and selectors that are easier to follow

• Circular image buttons are now flat by default
• All image buttons are now circular by default (might be a mistake)
• Popover image buttons might need a default background?
• Image buttons in OSDs have a duplicate background we probably don't want

BEFORE

AFTER

[wpkelso]

Don't know if there is any more planned work on this, but I'm not really a fan of losing the background in the pop-over buttons. In my opinion, if we remove the background, we lose the implication that some immediate action of consequence will happen if the icon is pushed, and it parses more as a label of some sort.

[danirabbit]

Yeah this is kind of dead code. In the Granite stylesheet branch I added backgrounds for popover buttons: elementary/granite#710

I think I also would like to adopt a convention about circles vs squares to distinguish between toggles and actions like in Quick Settings. Everything is just so complicated it really needs some super careful consideration and lots of testing

[wpkelso]

Yeah this is kind of dead code. In the Granite stylesheet branch I added backgrounds for popover buttons: elementary/granite#710

Ah, is stylesheet totally integrated into granite now? If that's the case, should this repo be archived for clarity?

---

Dunno where discussion about what convention to adopt should take place, but I suspect it's not this issue 😅

[danirabbit]

Ah, is stylesheet totally integrated into granite now?

@wpkelso no not yet! It's a goal of mine for Platform 9 but I haven't had time to work on it

[wpkelso]

Oh neat! I'd love to try and help where I can then with that.

Getting back on topic, this can probably be closed then?

[danirabbit]

@wpkelso I left it open just as draft in case there was any interesting code here that I might want to use later :)

Yeah! Here's the main branch: elementary/granite#703

I'll try to make some time soon to write up like the main motivations and big ideas

[wpkelso]

@danirabbit What are your thoughts on putting pull requests like this one under a For Parts or similar tag? The idea would be to easily sort out requests that are considered "dead" or out of active consideration/development, but might still be a source of interesting code or ideas.

[danirabbit]

I dunno if it's worth adding a whole separate tag. It is marked as draft already 🤷🏻‍♀️