Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Photometadata class more robust #781

Open
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

jeremypw
Copy link
Collaborator

May fix some issues with loading corrupt metadata.

  • Replaces an assert statement with throwing errors
  • Replaces deprecated GExiv2 methods with new error throwing ones and handle errors where necessary

@jeremypw
Copy link
Collaborator Author

The probable cause for reported crashes has now been found and fixed (see #785 ) so the changes here are mainly cosmetic - there is no evidence at the moment that they give rise to crashes. As there are no test defined in the codebase any regressions will have to be found by user testing I guess 😞 The codebase is littered with myriad functions that return null but in practice seems fairly stable so whether it is worth the work of updating it is debatable.

@jeremypw
Copy link
Collaborator Author

If desired I can separate smaller PRs for individual fixes that seem more worthwhile than others.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant