PlayerList: guard default_widget against null before MPRIS events - #330
Open
eltictacdicta wants to merge 2 commits into
Open
PlayerList: guard default_widget against null before MPRIS events#330eltictacdicta wants to merge 2 commits into
eltictacdicta wants to merge 2 commits into
Conversation
default_widget is only created when the sound indicator popover is opened, but MPRIS/DBus scanning starts at session start. When a media player appears before the popover has been opened, add_iface() and destroy_iface() access default_widget while it is still null, causing a wingpanel crash. Fixes elementary#324
jeremypw
reviewed
Aug 8, 2026
jeremypw
reviewed
Aug 8, 2026
Collaborator
|
Thanks for your first contribution and for finding the cause of this issue! |
jeremypw
approved these changes
Aug 9, 2026
jeremypw
left a comment
jeremypw
left a comment
Collaborator
There was a problem hiding this comment.
I cannot reproduce the issue on my machine anyway but these changes seem sane and do not introduce any regressions.
Author
Thanks for approving! For what it's worth, this was actually the only reliably reproducible crash I had — I documented it in #324. In my case it happened specifically when adjusting the volume while YouTube was open in Brave (I believe Chrome triggers it too, since they share the same underlying engine). After building with these changes, I haven't been able to reproduce the crash anymore. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
default_widget is only created when the sound indicator popover is opened, but MPRIS/DBus scanning starts at session start. When a media player appears before the popover has been opened, add_iface() and destroy_iface() access default_widget while it is still null, causing a wingpanel crash.
Fixes #324