DisplayWidget: animate with Granite.Symbol - #238
Open
danirabbit wants to merge 6 commits into
Open
Conversation
ryonakano
reviewed
Aug 22, 2026
| public const string ACTIVE = "active"; | ||
| } | ||
|
|
||
| public class Granite.Symbol : Granite.Bin { |
Member
There was a problem hiding this comment.
Is there any reason you used Granite namespace here although this file is not part of Granite?
Member
There was a problem hiding this comment.
If this can be a generic widget then I guess we should really move this to Granite instead of creating Granite.Symbol classes in many repositories.
Member
Author
There was a problem hiding this comment.
Yeah my idea was just to prototype this here and then move it to Granite before releasing. I can change the namespace before merging here if it looks okay :)
| 'src/Widgets/Device.vala', | ||
| 'src/Widgets/DisplayWidget.vala', | ||
| 'src/Widgets/PopoverWidget.vala', | ||
| 'src' / 'Widgets' / 'Symbol.vala', |
Member
There was a problem hiding this comment.
I don't think we need to use / (i.e. join_path()) if we don't have any variables; just 'src/Widgets/Symbol.vala', should fine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Kooha-2026-08-18-18-47-04.mp4