Use overlay to show empty message #2567
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/View/AbstractDirectoryView.vala
# Conflicts: # src/View/AbstractDirectoryView.vala
# Conflicts: # src/View/AbstractDirectoryView.vala
1 task
# Conflicts fixed: # src/View/AbstractDirectoryView.vala
zeebok
approved these changes
Jun 15, 2025
Contributor
zeebok
left a comment
zeebok
left a comment
There was a problem hiding this comment.
Code looks good. I can give this some testing tomorrow when I get home if desired
Contributor
Author
|
@zeebok Thanks for the review! Practical testing by another person is always preferable if possible but there is no hurry. |
lenemter
requested changes
Aug 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1224
Use an overlay in preference to using custom drawing or a stack so that user input and DnD still goes to view (except if dropped onto the empty label).
Custom drawing could probably still be done in Gtk4 using
SnapshotandPaintablefunctions but I would prefer to avoid this if possible.