fix: address CodeRabbit review issues on slack-full-width PR #2107#2132
Closed
devin-ai-integration[bot] wants to merge 8 commits intomasterfrom
Closed
fix: address CodeRabbit review issues on slack-full-width PR #2107#2132devin-ai-integration[bot] wants to merge 8 commits intomasterfrom
devin-ai-integration[bot] wants to merge 8 commits intomasterfrom
Conversation
- Capitalize 'markdown' to 'Markdown' in docs - Replace invalid empty rich_text block with valid Slack Block Kit structure - Add preview validation for full-width mode - Handle markdown table truncation gracefully (row-by-row instead of mid-row) - Align description rendering between dbt and elementary test templates - Update tests to reflect valid rich_text block and exact assertions Co-Authored-By: Itamar Hartstein <haritamar@gmail.com>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Contributor
|
👋 @devin-ai-integration[bot] |
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... 📒 Files selected for processing (13)
✏️ Tip: You can disable in-progress messages and the fortune message in your review settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: address CodeRabbit review issues on slack-full-width PR #2107
Summary
Addresses the CodeRabbit review comments from PR #2107. Key changes:
{"type": "rich_text", "elements": []}with a valid block containing a minimalrich_text_section. Emptyelementsarrays violate the Slack API and causeinvalid_blockserrors.list_of_dicts_to_markdown_tablenow accepts amax_lengthparam and removes rows from the end instead of lettingget_limited_markdown_msgcut mid-row, which produced malformed markdown._validate_preview_blocksinstead of bypassing it._get_elementary_test_templatedescription handling with_get_dbt_test_template(single block instead of separate header + context).Review & Testing Checklist for Human
{"type": "text", "text": " "}is valid per API but may render as a visible blank line. Test with--slack-full-widthin a real Slack channel._get_elementary_test_templateis acceptable. This changes the appearance of all elementary test alerts (not just full-width), switching from a two-block layout (header + context) to a singletext_section_block.test_rows_sampleto verify the(truncated)note appears and no markdown is cut mid-row.Notes
Summary by CodeRabbit
Release Notes
New Features
--slack-full-widthcommand-line flag to enable full-width Slack alert formatting, displaying test results as Markdown tables with improved visual presentation.Documentation