Fix: Find Qt5 (if enabled) in ElementalConfig.cmake #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If Qt5 has been enabled during build, then e.g. target Qt5::Widgets is exported as a install dependency via ElementalTargets.cmake. Thus ElementalConfig.cmake must find Qt5 and import these Qt5 targets or else the user will get errors like: CMake Error at CMakeLists.txt:... (add_executable): Target "..." links to target "Qt5::Widgets" but the target was not found. Perhaps a find_package() call is missing for an IMPORTED target, or an ALIAS target is missing?
|
|
JM1
added a commit
to JM1/ansible-role-jm1-dev-hpc
that referenced
this pull request
May 10, 2019
Elemental exports targets which link to Qt5 CMake targets but those are not loaded when including Elemental via CMake, breaking user libraries. Ref.: elemental/Elemental#275
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If Qt5 has been enabled during build, then e.g. target Qt5::Widgets is exported
as a install dependency via ElementalTargets.cmake. Thus ElementalConfig.cmake
must find Qt5 and import these Qt5 targets or else the user will get errors like:
CMake Error at CMakeLists.txt:... (add_executable):
Target "..." links to target "Qt5::Widgets" but the target was not found.
Perhaps a find_package() call is missing for an IMPORTED target, or an
ALIAS target is missing?