Skip to content

Allow admins to see policy server-flagged events #18585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 41 commits into
base: develop
Choose a base branch
from
Open

Allow admins to see policy server-flagged events #18585

wants to merge 41 commits into from

Conversation

turt2live
Copy link
Member

Requires #18238

Real diff: 881d521...travis/flag-ps-events

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request includes a changelog file. The entry should:
    • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
    • Use markdown where necessary, mostly for code blocks.
    • End with either a period (.) or an exclamation mark (!).
    • Start with a capital letter.
    • Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
  • Code style is correct (run the linters)

turt2live and others added 30 commits March 13, 2025 15:02
@turt2live
Allow admins to see soft failed events
d1c73e7
@turt2live
changelog
a855b55
@turt2live @github-actions
Attempt to fix linting
8f2fa30
@turt2live
Empty commit to fix CI
331bc7c
@anoadragon453
Bump db txn expected count in relations tests
b453b1a 
As we're now performing another db txn to check if the user is an admin.
@turt2live
Merge branch 'develop' into travis/admin-soft-fail
8e823be
@turt2live
Switch to a general concept of "CS API extensions" on a per-user basis
a12af45
@turt2live
Reset aggregations counts
efa5ad9
@turt2live
Add some untested tests
24c809f
@turt2live @github-actions
Attempt to fix linting
f24386a
@turt2live
kick ci
38a8937
@turt2live
I guess the CI doesn't want us to do that
043bd86
@turt2live
oops
99b9ee2
@turt2live @github-actions
Attempt to fix linting
8908312
@turt2live
kick ci
1262b10
@turt2live
actually render new docs
7344990
@turt2live
Appease linter
f967bbb
@turt2live @github-actions
Attempt to fix linting
b2e4a63
@turt2live
kick ci
88b4723
@turt2live
Create internal metadata properly in tests
1c7e7f1
@turt2live
Bump db txn count in tests
2800943
@turt2live
More txn count bumps
b38c208
@turt2live
await
25ef8dd
@turt2live
fix internal_metadata?
37a38f8
@turt2live
Flip if order to reduce db transactions in the general case
7e8e66e
@turt2live
ok, so pop breaks things
bcf3a89
@turt2live
Maybe there's just a bunch of checks behind the scenes
5c4ba56
@turt2live
one more time
61ba901
@turt2live
Merge branch 'travis/admin-soft-fail' into travis/flag-ps-events
881d521
@turt2live
Track internal metadata for policy server bool
c3f2b94
@turt2live turt2live changed the title Travis/flag ps events Allow admins to see policy server-flagged events Jun 20, 2025
@github-actions github-actions bot deployed to PR Documentation Preview June 20, 2025 18:42 Active
@github-actions github-actions bot deployed to PR Documentation Preview June 20, 2025 18:46 Active
@turt2live turt2live marked this pull request as ready for review June 20, 2025 18:49
@turt2live turt2live requested a review from a team as a code owner June 20, 2025 18:49
@github-actions github-actions bot deployed to PR Documentation Preview June 20, 2025 19:04 Active
@github-actions github-actions bot deployed to PR Documentation Preview June 20, 2025 19:09 Active
@github-actions github-actions bot deployed to PR Documentation Preview June 20, 2025 19:14 Active
@github-actions github-actions bot deployed to PR Documentation Preview June 20, 2025 19:18 Active
MadLittleMods
MadLittleMods reviewed Jun 20, 2025
View reviewed changes
docs/admin_api/client_server_api_extensions.md
@@ -0,0 +1,51 @@
# Client-Server API Extensions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed in the #synapse-dev:matrix.org room

@MadLittleMods MadLittleMods requested a review from a team June 20, 2025 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MadLittleMods MadLittleMods MadLittleMods left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@turt2live @MadLittleMods @anoadragon453