Move registrations off the main worker #18552
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandhose
force-pushed
the
quenting/user-registrations-off-main
branch
from
482710c to
8011a38
Compare
reivilibre
reviewed
Jun 18, 2025
Comment on lines
-769
to
-770
| # Only call the account validity module(s) on the main process, to avoid | ||
| # repeating e.g. database writes on all of the workers. |
There was a problem hiding this comment.
maybe it'd be worth adding some warning somewhere (upgrade notes? elsewhere?) about the fact this callback will now run on any worker capable of registration.
Not sure if we have active customers relying on it, or know of any community use cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mainly moving a few store methods around. Note that this doesn't yet remove the replication servlet to avoid breaking during rollout.