Add report user API from MSC4260

[turt2live]

matrix-org/matrix-spec-proposals#4260

Pull Request Checklist

• Pull request is based on the develop branch
• Pull request includes a changelog file. The entry should:
  • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
  • Use markdown where necessary, mostly for code blocks.
  • End with either a period (.) or an exclamation mark (!).
  • Start with a capital letter.
  • Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
• Code style is correct
  (run the linters)

[turt2live]

test failures appear unrelated

[sandhose]

Overall looks good

[anoadragon453]

Some further notes and ideas below.

[sandhose]

Very non-blocking concerns, happy to merge as-is, just let me know

[anoadragon453]

Seems we probably should have defined a way to delete these reports during the MSC process... Do we have a plan to clear reports out once they're handled?

Otherwise the below is the only blocking comment.

[turt2live]

Seems we probably should have defined a way to delete these reports during the MSC process... Do we have a plan to clear reports out once they're handled?

Like any other report: no. Implementations are left to their own decisions in this regard.

We'll add applicable admin APIs later - I'd like to avoid overloading this PR.

[anoadragon453]

Seems we probably should have defined a way to delete these reports during the MSC process... Do we have a plan to clear reports out once they're handled?

Like any other report: no. Implementations are left to their own decisions in this regard.

We'll add applicable admin APIs later - I'd like to avoid overloading this PR.

Sorry, I wasn't suggesting adding any more APIs to this PR. I was more wondering if there were plans to create tooling to remove reports. It sounds like there are, but from a different angle that the C-S API.

Happy to discuss that more in a separate issue/MSC.

[turt2live]

honestly, the hope is to bypass the Synapse database entirely one day, but that's very long term thoughts. In the meantime, we'll slowly add admin APIs as we (T&S) need them, if others don't contribute them.

[anoadragon453]

This LGTM. Thanks for working on this and other T&S features ❤️

[anoadragon453]

Non-blocking, but would it not be useful for the reporter to get an error here telling them that the homeserver operator likely don't do much about remote users? And tell them to contact the remote homeserver's operator instead?

[turt2live]

Possibly/probably, though IIRC this is in the MSC.

One day we do also hope to support federated reports.