Skip to content

Remove the previous version of the AttributedStringBuilder #4596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 28, 2025
Merged

Remove the previous version of the AttributedStringBuilder #4596

merged 4 commits into from
Oct 28, 2025
+596 −1,274

Conversation

@stefanceriu
Copy link
Member

No description provided.

@stefanceriu stefanceriu added the pr-misc for other changes label Oct 8, 2025
@github-actions
Copy link

github-actions bot commented Oct 8, 2025 •
edited
Loading

Warnings
⚠️ Please provide a description for this PR.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 0fd0054

@stefanceriu stefanceriu force-pushed the stefan/coreTextNoMore branch from d3b5273 to 473b11b Compare October 9, 2025 06:14
@codecov
Copy link

codecov bot commented Oct 9, 2025 •
edited
Loading

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
1087 1 1086 0
View the full list of 1 ❄️ flaky test(s) 
HomeScreenViewModelTests::testDeclineInvite()

Flake rate in main: 25.99% (Passed 225 times, Failed 79 times)

Stack Traces | 2.1s run time 
XCTAssertEqual failed: ("["someAwesomeRoomId2", "someAwesomeRoomId1"]") is not equal to ("["someAwesomeRoomId2"]") (UnitTests/Sources/HomeScreenViewModelTests.swift:345)

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@stefanceriu
Remove the first version of the AttributedString builder
2dffcab 
Remvoe test stuf

# Conflicts:
#	ElementX/Sources/Other/HTMLParsing/AttributedStringBuilder.swift
#	ElementX/Sources/Other/HTMLParsing/AttributedStringBuilderV1.swift
#	ElementX/Sources/Other/HTMLParsing/DTHTMLElement+AttributedStringBuilder.swift
@stefanceriu
Rename the AttributedStringBuilder file name
6b899fc
@stefanceriu
Remove the DTCoreText dependency
cefb12d
@stefanceriu
Update preview test snapshots
0fd0054
@stefanceriu stefanceriu force-pushed the stefan/coreTextNoMore branch from ff4fbba to 0fd0054 Compare October 24, 2025 11:10
@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@stefanceriu stefanceriu marked this pull request as ready for review October 24, 2025 11:21
@stefanceriu stefanceriu requested a review from a team as a code owner October 24, 2025 11:21
@stefanceriu stefanceriu requested review from pixlwave and removed request for a team October 24, 2025 11:21
pixlwave
pixlwave approved these changes Oct 28, 2025
View reviewed changes
Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pixlwave pixlwave merged commit 25a2a65 into develop Oct 28, 2025
8 checks passed
@pixlwave pixlwave deleted the stefan/coreTextNoMore branch October 28, 2025 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pixlwave pixlwave pixlwave approved these changes

Assignees

No one assigned

Labels

pr-misc for other changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@stefanceriu @pixlwave