Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codecov: Add token for codecov-action@v3 to fix coverage report #2727

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

manuroe
Copy link
Member

@manuroe manuroe commented Apr 22, 2024

Moving to v4 is blocked because of a fundamental issue with codecov/codecov-action#1279 on our mac runners and because the reported coverage is decreasing with v4

Will replace #2719.

Moving to v4 is blocked because of a fundamental issue with codecov/codecov-action#1279 on our mac runners and because the reported coverage is [decreasing with v4](https://app.codecov.io/gh/element-hq/element-x-ios/pull/2719/flags)
@manuroe manuroe requested a review from a team as a code owner April 22, 2024 10:27
@manuroe manuroe requested review from Velin92 and removed request for a team April 22, 2024 10:27
Copy link

sonarcloud bot commented Apr 22, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

Warnings
⚠️ Please add a changelog.
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.

Generated by 🚫 Danger Swift against 6bf260c

Copy link

codecov bot commented Apr 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.70%. Comparing base (bdacea1) to head (6bf260c).
Report is 6 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #2727       +/-   ##
============================================
+ Coverage    62.56%   74.70%   +12.14%     
============================================
  Files          582      583        +1     
  Lines        40209    40442      +233     
============================================
+ Hits         25155    30211     +5056     
+ Misses       15054    10231     -4823     
Flag Coverage Δ
integrationtests 32.43% <ø> (?)
uitests 28.97% <ø> (?)
unittests 62.48% <ø> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@manuroe manuroe merged commit a3ec0b8 into develop Apr 22, 2024
11 checks passed
@manuroe manuroe deleted the manuroe/code-action-v3-token branch April 22, 2024 12:59
stefanceriu added a commit that referenced this pull request Sep 10, 2024
stefanceriu added a commit that referenced this pull request Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants