-
Notifications
You must be signed in to change notification settings - Fork 318
Update notification style #5607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, although it will cause a few conflicts with #5595 🥲 .
| messages: List<NotifiableMessageEvent>, | ||
| currentUser: MatrixUser, | ||
| imageLoader: ImageLoader, | ||
| @ColorInt color: Int, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit for this one and others: tintColor or brandColor instead maybe?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since at the end it's used for NotificationCompat.Builder.setColor() I think this name is quite ok...
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #5607 +/- ##
========================================
Coverage 81.69% 81.69%
========================================
Files 2389 2389
Lines 64887 64893 +6
Branches 8236 8237 +1
========================================
+ Hits 53009 53014 +5
Misses 8827 8827
- Partials 3051 3052 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|



Content
Use Compound icons for the notification action. Those icon are never used on mobile running API 24+ but may be used by wearable devices.
Let the notification use the brand color if available.
Also remove the green Element logo from the troubleshoot notification.
Motivation and context
Application customization
Screenshots / GIFs
Tests
Tested devices
Checklist