Skip to content

Conversation

@bmarty
Copy link
Member

@bmarty bmarty commented Oct 24, 2025

Content

Use Compound icons for the notification action. Those icon are never used on mobile running API 24+ but may be used by wearable devices.
Let the notification use the brand color if available.
Also remove the green Element logo from the troubleshoot notification.

Motivation and context

Application customization

Screenshots / GIFs

Before After
image image

Tests

  • Login to an account which support brand color.
  • Observe how the notification are rendered.

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 24
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • You've made a self review of your PR

@bmarty bmarty requested a review from a team as a code owner October 24, 2025 15:29
@bmarty bmarty added the PR-Misc For other changes label Oct 24, 2025
@bmarty bmarty requested review from jmartinesp and removed request for a team October 24, 2025 15:29
@github-actions
Copy link
Contributor

github-actions bot commented Oct 24, 2025

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/AGXXod

Copy link
Member

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although it will cause a few conflicts with #5595 🥲 .

messages: List<NotifiableMessageEvent>,
currentUser: MatrixUser,
imageLoader: ImageLoader,
@ColorInt color: Int,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit for this one and others: tintColor or brandColor instead maybe?

Copy link
Member Author

@bmarty bmarty Oct 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since at the end it's used for NotificationCompat.Builder.setColor() I think this name is quite ok...

@codecov
Copy link

codecov bot commented Oct 24, 2025

Codecov Report

❌ Patch coverage is 94.64286% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.69%. Comparing base (9a39594) to head (1080319).
⚠️ Report is 15 commits behind head on develop.

Files with missing lines Patch % Lines
...push/impl/notifications/NotificationDataFactory.kt 80.00% 1 Missing ⚠️
...es/push/impl/notifications/NotificationRenderer.kt 87.50% 0 Missing and 1 partial ⚠️
...braries/push/impl/troubleshoot/NotificationTest.kt 83.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #5607   +/-   ##
========================================
  Coverage    81.69%   81.69%           
========================================
  Files         2389     2389           
  Lines        64887    64893    +6     
  Branches      8236     8237    +1     
========================================
+ Hits         53009    53014    +5     
  Misses        8827     8827           
- Partials      3051     3052    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sonarqubecloud
Copy link

@bmarty bmarty merged commit a9bc148 into develop Oct 24, 2025
31 of 32 checks passed
@bmarty bmarty deleted the feature/bma/notificationStyle branch October 24, 2025 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR-Misc For other changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants