Fix issues with WorkManager on Android 12 and below #5606

jmartinesp · 2025-10-24T10:35:57Z

Content

Remove setExpedited value for Android 12 and lower, since it's not needed.
Add getForegroundInfo in case some OS behaves unexpectedly and still forces us to display the foreground service notification to run the worker.

Motivation and context

Fix an issue reported in the Element X Android public room, where the WorkManager crashed because the setExpedited option used in the worker request would force the app to display a notification we weren't ready for.

Tests

On Android <= 12, enabled the 'sync notifications using workmanager' feature and receive a couple of notifications.

Notifications should arrive normally.

Tested devices

Physical
Emulator
OS version(s): 11, 12, 13.

Checklist

Changes have been tested on an Android device or Android emulator with API 24
UI change has been tested on both light and dark themes
Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
Pull request is based on the develop branch
Pull request title will be used in the release note, it clearly define what will change for the user
Pull request includes screenshots or videos if containing UI changes
You've made a self review of your PR

jmartinesp · 2025-10-24T10:39:08Z

@YamatoRyou since I can't reproduce the issue myself, can I ask you to test the debug APK that will be attached to this PR and see if it fixes your issue with workmanager? If it doesn't, please rageshake again and let us know.

github-actions · 2025-10-24T10:41:04Z

📱 Scan the QR code below to install the build (arm64 only) for this PR.

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/MK4jA6

YamatoRyou · 2025-10-24T10:57:40Z

@YamatoRyou since I can't reproduce the issue myself, can I ask you to test the debug APK that will be attached to this PR and see if it fixes your issue with workmanager? If it doesn't, please rageshake again and let us know.

I just installed the debug APK and tested it.
On this device, the previously mentioned issue has resolved.

jmartinesp · 2025-10-24T13:51:10Z

Sorry @YamatoRyou can I ask you to test again the newly built APK after some changes I made? This should make the 'Fetching notifications...' notification not necessary on your Android OS version, but I want to double check notifications still work as expected after removing it.

If you want to test it, you can just tap on the link/scan the QR code again.

YamatoRyou · 2025-10-24T14:14:43Z

Sorry @YamatoRyou can I ask you to test again the newly built APK after some changes I made? This should make the 'Fetching notifications...' notification not necessary on your Android OS version, but I want to double check notifications still work as expected after removing it.

If you want to test it, you can just tap on the link/scan the QR code again.

It looks normal. I also tested the incoming call UI and it also works fine.

App: 99cd75b5

bmarty

Thanks for the fix. Some remarks

...lin/io/element/android/libraries/push/impl/workmanager/SyncNotificationWorkManagerRequest.kt

...c/main/kotlin/io/element/android/libraries/push/impl/workmanager/FetchNotificationsWorker.kt

...io/element/android/libraries/push/impl/workmanager/SyncNotificationWorkManagerRequestTest.kt

...c/main/kotlin/io/element/android/libraries/push/impl/workmanager/FetchNotificationsWorker.kt

…Manager on Android 12 and below This may be a MIUI-only issue as I couldn't reproduce it with several emulators on Android 11, 12 and 13.

…lder versions

Instead of using Robolectric with API < 33 (since Pro uses minSdk 33) use a `BuildVersionSdkIntProvider`

bmarty

Sorry, a few thoughts about the added code.

...c/main/kotlin/io/element/android/libraries/push/impl/workmanager/FetchNotificationsWorker.kt

libraries/push/impl/src/main/AndroidManifest.xml

codecov · 2025-10-27T12:16:55Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.70%. Comparing base (9baf948) to head (44125e3).
⚠️ Report is 17 commits behind head on develop.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop    #5606   +/-   ##
========================================
  Coverage    81.70%   81.70%           
========================================
  Files         2390     2390           
  Lines        64902    64909    +7     
  Branches      8247     8248    +1     
========================================
+ Hits         53025    53033    +8     
+ Misses        8821     8820    -1     
  Partials      3056     3056

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…t it to be dead code

bmarty

Thanks for the update. I have pushed a cleanup commit. Set to auto merge so we can have it in the next nightly.

bmarty · 2025-10-28T19:34:20Z

libraries/ui-strings/src/main/res/values/localazy.xml

  <string name="common_advanced_settings">"Advanced settings"</string>
  <string name="common_an_image">"an image"</string>
  <string name="common_analytics">"Analytics"</string>
+  <string name="common_android_notification_sync_notifications_foreground_service_title">"Fetching notifications…"</string>


Note: I have removed this key from Localazy as the string is not used now.

sonarqubecloud · 2025-10-28T19:44:08Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

bmarty reviewed Oct 24, 2025

View reviewed changes

jmartinesp added 4 commits October 27, 2025 11:20

Add getForegroundInfo implementation to try to fix issues with Work…

5da7511

…Manager on Android 12 and below This may be a MIUI-only issue as I couldn't reproduce it with several emulators on Android 11, 12 and 13.

Use setExpedited only on Android 13 or higher, it's not needed on o…

5a7a0ee

…lder versions

Use an actual string resource, fix tests

b8e13c9

Fix review comments

50f2209

jmartinesp force-pushed the fix/workmanager-expedited-on-android-12-below branch from 6ac271f to 50f2209 Compare October 27, 2025 10:32

jmartinesp changed the title ~~Add getForegroundInfo implementation to try to fix issues with Work…~~ Fix issues with WorkManager on Android 12 and below Oct 27, 2025

jmartinesp added the PR-Bugfix For bug fix label Oct 27, 2025

jmartinesp marked this pull request as ready for review October 27, 2025 10:37

jmartinesp requested a review from a team as a code owner October 27, 2025 10:37

jmartinesp requested review from bmarty and removed request for a team October 27, 2025 10:37

Fix broken test with Element Pro:

11cf813

Instead of using Robolectric with API < 33 (since Pro uses minSdk 33) use a `BuildVersionSdkIntProvider`

bmarty reviewed Oct 27, 2025

View reviewed changes

...c/main/kotlin/io/element/android/libraries/push/impl/workmanager/FetchNotificationsWorker.kt Outdated Show resolved Hide resolved

libraries/push/impl/src/main/AndroidManifest.xml Outdated Show resolved Hide resolved

bmarty added the Z-NextRelease For issues and PRs which should be included in the NextRelease. label Oct 28, 2025

jmartinesp added 2 commits October 28, 2025 09:56

Remove getForegroundInfo and the associated permission, as we expec…

a701200

…t it to be dead code

Fix lint issues

54a7f81

jmartinesp requested a review from bmarty October 28, 2025 12:35

Cleanup NotificationIdProvider

44125e3

bmarty approved these changes Oct 28, 2025

View reviewed changes

bmarty enabled auto-merge (squash) October 28, 2025 19:35

bmarty merged commit 84d0338 into develop Oct 28, 2025
31 of 32 checks passed

bmarty deleted the fix/workmanager-expedited-on-android-12-below branch October 28, 2025 20:06

Fix issues with WorkManager on Android 12 and below #5606

Fix issues with WorkManager on Android 12 and below #5606

Uh oh!

Conversation

jmartinesp commented Oct 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Content

Motivation and context

Tests

Tested devices

Checklist

Uh oh!

jmartinesp commented Oct 24, 2025

Uh oh!

github-actions bot commented Oct 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

YamatoRyou commented Oct 24, 2025

Uh oh!

jmartinesp commented Oct 24, 2025

Uh oh!

YamatoRyou commented Oct 24, 2025

Uh oh!

bmarty left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bmarty left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Oct 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

bmarty left a comment

Choose a reason for hiding this comment

Uh oh!

bmarty Oct 28, 2025

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Oct 28, 2025

Quality Gate passed

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

jmartinesp commented Oct 24, 2025 •

edited

Loading

github-actions bot commented Oct 24, 2025 •

edited

Loading

codecov bot commented Oct 27, 2025 •

edited

Loading