-
Notifications
You must be signed in to change notification settings - Fork 334
Display non-technical error on media gallery #5487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Display non-technical error on media gallery #5487
Conversation
This way, we can customise the error to display (`throwable.message`, `throwable.localizeMessage`, or any other error message we want).
…` to this to display a generic error instead of the technical one coming from Rust
…a timeline initialization fails
|
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #5487 +/- ##
===========================================
- Coverage 81.93% 81.93% -0.01%
===========================================
Files 2371 2371
Lines 67207 67215 +8
Branches 8112 8115 +3
===========================================
+ Hits 55069 55071 +2
- Misses 9163 9167 +4
- Partials 2975 2977 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note this Failed to load media message comes from a fake Exception(message = "Failed to load media"). This is not localized and in a real example can expose internal state of the app.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we should ever use the message exception anyway :/
We probably need some clean up on the error ui through the entire app, which might require some design/product.



This way, we can customise the error to display (
throwable.message,throwable.localizeMessage, or any other error message we want).Content
Motivation and context
Fixes #5483
Screenshots / GIFs
Tests
Tested devices
Checklist