Hide room header buttons if the room hasn't been created yet. #31092
+141
−489
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Half-Shot
changed the title
|
Looks good. Note: Users can still press the avatar to access room settings but that is a small use case and what you have here will help so much! |
daniellekirkwood
approved these changes
Oct 30, 2025
Oh, we can do the last mile of changes there. I'll take a look. |
Half-Shot
commented
Oct 30, 2025
|
|
||
| import React, { type JSX, useCallback, useMemo, useState } from "react"; | ||
| import { Body as BodyText, Button, IconButton, Menu, MenuItem, Tooltip } from "@vector-im/compound-web"; | ||
| import { Text, Button, IconButton, Menu, MenuItem, Tooltip } from "@vector-im/compound-web"; |
There was a problem hiding this comment.
N.B. BodyText is deprecated and a passthrough to Text, so I did some cleanup on the side here.
dbkr
approved these changes
Nov 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #31072
This goes with the nuclear option of hiding the header buttons for a room before it's been created, as currently none of them work. The alternative would be to go round the houses and add suitable mocks to
LocalRoomof the actual room interface, but this seems overkill to my eyes.Checklist
public/exportedsymbols have accurate TSDoc documentation.