Make shared component build work in isolation #31066
Conversation
* Add deps that were missing because they were getting picked up from element-web main but shared-components needs itself * Exclude test files from dts generation * Bump version
There was a problem hiding this comment.
Can we take this opportunity to tidy the deps, e.g. temporal-polyfill is now depended on by both shared-components and element-web but actually only used by shared-components... Or is this needed because we bypass the dependencies of the subpackage and its build system? in which case that feels super brittle and we should stop doing that otherwise we might end up with shared components in isolation working but within element web not due to dep version mismatches
|
Indeed, we do need the dependencies as we import the typescript source directly, like we do with js-sdk, although that has fewer dependencies so I assume it's never been an issue. We can certainly switch to consuming the built output of shared-components, it will mean more steps to run for dev but is probably the "right" choice - wdyt? |
We install js-sdk as a dependency so we get its dependencies transitively, we don't git clone it and reference it by fs path. We need certain additional dev deps because we use the src, rather than lib but no runtime deps.
I think it is the right choice, we could use |
|
I suppose if we just added it as a dependency then we'd still get the dependencies transitively and we could continue importing the ts directly? |
|
Yes that is an option, there is always potential for inconsistency between ew and other consumers given the build system is being bypassed |
scripts/docker-package.sh
Outdated
| DIST_VERSION=$("$DIR"/normalize-version.sh "$DIST_VERSION") | ||
|
|
||
| # Build resources as the shared components need them | ||
| yarn run build:res |
There was a problem hiding this comment.
should this maybe be in shared-component prepare script?
* build:res on the parent as part of shared component prepare * link shared component repo inn docker build
so it gets bundled rather than left as a relative import to the json file
src/settings/Settings.tsx
Outdated
|
|
||
| import React, { type ReactNode } from "react"; | ||
| import { STABLE_MSC4133_EXTENDED_PROFILES, UNSTABLE_MSC4133_EXTENDED_PROFILES } from "matrix-js-sdk/src/matrix"; | ||
| // Import i18n.tsx instead of languageHandler to avoid circular deps |
Co-authored-by: Michael Telatynski <[email protected]>
This now also changes EW s it consumes the shared components via their exported, built bundle rather than the source, and, as a result, is quite large.
Some of the changes that might seem more surprising:
Summary of changes prior to switching shared components to be consumed from the built package:
Checklist
public/exportedsymbols have accurate TSDoc documentation.