Move room name, avatar, and topic to IOpts.

[kaylendog]

Move room name, avatar, and topic to IOpts, over using ICreateRoomOpts. This will facilitate the logic in #30877.

Checklist

• I have read through review guidelines and CONTRIBUTING.md.
• Tests written for new code (and old code if feasible).
• New or updated public/exported symbols have accurate TSDoc documentation.
• Linter and other CI checks pass.
• I have licensed the changes to Element by completing the Contributor License Agreement (CLA)

[kaylendog]

I'm not sure if it's worth addressing the coverage issues in this PR, since as far as I can tell it's related to the underlying code not having good coverage.

[t3chguy]

I'm not sure if it's worth addressing the coverage issues in this PR, since as far as I can tell it's related to the underlying code not having good coverage.

When would the underlying code get good coverage then though? We normally mandate that refactors and the like do have to bring the coverage up to scratch otherwise it'll never be done

[kaylendog]

I'm not sure if it's worth addressing the coverage issues in this PR, since as far as I can tell it's related to the underlying code not having good coverage.

When would the underlying code get good coverage then though? We normally mandate that refactors and the like do have to bring the coverage up to scratch otherwise it'll never be done

It just seems a bit silly to write tests for existing uncovered code that I haven't modified in an otherwise unrelated refactoring PR. To me, it'd make more sense for such tests to go in their own PR dedicated explicitly to improving coverage. If it's mandated, however, I'll attempt to write some tests for it and include them here.

[t3chguy]

We don't have a way of bypassing the sonarcloud coverage gate without also bypassing a bunch of merge queue tests (until #30630 lands) so we are quite averse to bypassing it as it means a plethora of tests won't get executed. I doubt you want to block on #30630 landing first though

[kaylendog]

We don't have a way of bypassing the sonarcloud coverage gate without also bypassing a bunch of merge queue tests (until #30630 lands) so we are quite averse to bypassing it as it means a plethora of tests won't get executed. I doubt you want to block on #30630 landing first though

That's fair. I'll commit to writing tests here then.

[richvdh]

LGTM

[andybalaam]

@MidhunSureshR @t3chguy this is now ready for re-review.

I added 3 commits with tests to increase coverage:

• cd3a42f
• 3325356
• 6745f17

When this passes review I will rebase.

[andybalaam]

Ah, I see that Rich's review is enough so I will rebase and queue for merge now.