Skip to content

Update the mobile_guide page to the new design and link out to Element X by default. #30172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

Update the mobile_guide page to the new design and link out to Element X by default. #30172

wants to merge 6 commits into from

Conversation

pixlwave
Copy link
Member

@pixlwave pixlwave commented Jun 19, 2025 •
edited
Loading

This PR reverts #30104 (restoring #30006) and makes the following additional changes:

  • Fix yarn build on Windows.
    • Webpack was failing to pack the gradient image defined in the CSS file.
    • Handling the mobile_guide assets in getAssetOutputPath resolved this.
  • Set the default mobile app variant to Element X as requested by product.
    • Anyone who wishes to continue linking to Element Classic will need to set mobile_guide_app_variant to "classic" as detailed in the configuration docs.

Linking to #30056 for visibility.

pixlwave added 3 commits June 19, 2025 12:28
@pixlwave
Reapply "Update the mobile_guide page to the new design. (element-hq#…
2e6b385 
…30006)" (element-hq#30104)

This reverts commit c51823d.
@pixlwave
Use Element X as the default mobile_guide_app_variant when omitted.
7812fb4
@pixlwave
Fix a build error on Windows.
abcb85b 
Additionally revert "Remove unnecessary <%= require %> usages" and let webpack handle all of the assets (without a manual copy rule).
@pixlwave pixlwave requested a review from a team as a code owner June 19, 2025 18:05
@pixlwave pixlwave requested review from t3chguy and florianduros June 19, 2025 18:05
@pixlwave pixlwave changed the title Update the mobile_guide page to the new design with store links to Element X by default. Update the mobile_guide page to the new design with store links for Element X by default. Jun 19, 2025
@pixlwave pixlwave changed the title Update the mobile_guide page to the new design with store links for Element X by default. Update the mobile_guide page to the new design and show link out to Element X by default. Jun 19, 2025
@pixlwave pixlwave changed the title Update the mobile_guide page to the new design and show link out to Element X by default. Update the mobile_guide page to the new design and link out to Element X by default. Jun 19, 2025
@pixlwave
Copy link
Member Author

pixlwave commented Jun 19, 2025 •
edited
Loading

And now the screenshot tests fail on Linux. But not my local Linux where they pass. I now appreciate how nice it is to only have to target one OS 🙈

@pixlwave pixlwave marked this pull request as draft June 19, 2025 18:29
@t3chguy
Copy link
Member

t3chguy commented Jun 20, 2025

@pixlwave looks like its loading the images wrong

image

double /mobile_guide/

@pixlwave
Copy link
Member Author

Yeah, I've reverted the use of those requires. That wasn't part of the fix on Windows (just seemed nice to do), so 🤞 this should all be happy now.

@pixlwave
Copy link
Member Author

Nice, looks like it passed this time.

@pixlwave pixlwave marked this pull request as ready for review June 20, 2025 09:33
t3chguy
t3chguy requested changes Jun 20, 2025
View reviewed changes
Copy link
Member

@t3chguy t3chguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, all the screenshots seem to say Element Pro - that doesn't seem right

@pixlwave
Copy link
Member Author

Hmm, all the screenshots seem to say Element Pro - that doesn't seem right

My bad, completely missed that last time round.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t3chguy t3chguy t3chguy approved these changes

@florianduros florianduros Awaiting requested review from florianduros florianduros is a code owner automatically assigned from element-hq/element-web-reviewers

Assignees
No one assigned
Labels
T-Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pixlwave @t3chguy