Skip to content

Update settings toggles to use consistent design across app. #30169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 29 commits into
base: develop
Choose a base branch
from

Conversation

Half-Shot
Copy link
Member

@Half-Shot Half-Shot commented Jun 19, 2025

This changes the settings toggles across Element to use a left hand side toggle, which improves our accessibility across the app. In a few places we also switch to SettingsFlag where we can, to reduce reuse of common patterns. In a handful of places this also aligns the help text of a switch to directly below it, or adds a disabled reason when a toggle is disabled without a reason presented to a user.

Changes areas (with screenshot test):

  • ApperanceTab
  • CreateRoomDialog
  • DeclineInviteDialog
  • DevToolsDialog
  • ReportRoomDialog
  • RoomUpgradeWarningDialog
  • WidgetCapabilitiesPromptDialog
  • WidgetOpenIDPermissionsDialog
  • EnableLiveShare
  • General Room Tab
  • Notifications
  • NotificationSettings (new)
  • SecurityTab
  • RoomSecurityTab
  • VoipRoomSettingsTab
  • PreferencesTab
  • VoiceUserSettingsTab
  • SpaceSettingsVisibilityTab
  • SpaceSettingsVisibilityTab

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • I have licensed the changes to Element by completing the Contributor License Agreement (CLA)

@Half-Shot Half-Shot force-pushed the hs/update-toggles-to-use-consistent-style branch from f10d439 to 5982a4c Compare June 19, 2025 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant