Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Permission Settings Don't Protect Against Self-Changes #26297

Open
Windows81 opened this issue Oct 4, 2023 · 0 comments · May be fixed by #28926
Open

Permission Settings Don't Protect Against Self-Changes #26297

Windows81 opened this issue Oct 4, 2023 · 0 comments · May be fixed by #28926
Labels
A-Power-Levels The permissions that users have in rooms and spaces A-Room-Settings O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect

Comments

@Windows81
Copy link

Windows81 commented Oct 4, 2023 •
edited
Loading

Steps to reproduce

I use Schildi, though the steps are also reproduceable on Element itself:

  1. Navigate to a space's settings.

image

  1. Roles & Permissions » Priviledged Users

image

Outcome

What did you expect?

For an action that can potentially brick any space where the only admin is you, it's expected that there is a warning popup if you're modifying your own permission level.

What happened instead?

Your role changes right away. If the space had only one admin before, it now has zero admins. Under default settings, that'll essentially brick the entire space and prevent any metadata changes from ever emerging.

Operating system

Windows 11

Browser information

Ungoogled Chromium 117

URL for webapp

app.schildi.chat

Application version

SchildiChat version: 1.11.30-sc.2

Homeserver

matrix.org

Will you send logs?

No
@kerryarchibald kerryarchibald added S-Major Severely degrades major functionality or product features, with no satisfactory workaround A-Room-Settings O-Occasional Affects or can be seen by some users regularly or most users rarely A-Power-Levels The permissions that users have in rooms and spaces labels Oct 6, 2023
@t3chguy t3chguy changed the title Space Permission Settings Don't Protect Against Self-Changes Permission Settings Don't Protect Against Self-Changes Nov 26, 2024
@t3chguy t3chguy mentioned this issue Nov 26, 2024
Closed
@MarcWadai MarcWadai linked a pull request Jan 8, 2025 that will close this issue
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Power-Levels The permissions that users have in rooms and spaces A-Room-Settings O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: warn self change on roles settings tchapgouv/element-web
2 participants
@kerryarchibald @Windows81