Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Last admin warning dialog not showing when changing role in room settings #28547

Closed
MarcWadai opened this issue Nov 26, 2024 · 1 comment
Closed
Labels
A-Room-Settings O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Enhancement

Comments

@MarcWadai
Copy link

Your use case

What would you like to do?

We have a last admin dialog warning showing when changing the role on the right panel menu of the room. but we don"t have this behavior when changing on the setting screen of the room.

image

image

I would like to also add this warning when changing members roles on this screen.

Why would you like to do it?

Not having a warning confirmation modal here can lead to irreversible consequences for the user. Since we already have this behavior on one part of the application, it can be beneficial to apply it everywhere.

How would you like to achieve it?

Using the same code in UserInfo.tsx, we have the dialog warnSelfDemote, but managing to also do the check in RolesRoomSettingsTab.tsx when onUserPowerLevelChanged is changing.

Have you considered any alternatives?

No response

Additional context

No response

@dosubot dosubot bot added A-Room-Settings O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist labels Nov 26, 2024
@t3chguy
Copy link
Member

t3chguy commented Nov 26, 2024

Duplicate of #26297

@t3chguy t3chguy marked this as a duplicate of #26297 Nov 26, 2024
@t3chguy t3chguy closed this as not planned Won't fix, can't repro, duplicate, stale Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Room-Settings O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Enhancement
Projects
None yet
Development

No branches or pull requests

2 participants