Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compress images before sending #1547

Merged
merged 5 commits into from
Jun 26, 2020
Merged

Compress images before sending #1547

merged 5 commits into from
Jun 26, 2020

Conversation

onurays
Copy link
Contributor

@onurays onurays commented Jun 25, 2020 •
edited
Loading

No description provided.

@onurays onurays requested a review from bmarty June 25, 2020 07:11
@onurays onurays self-assigned this Jun 25, 2020
@onurays onurays linked an issue Jun 25, 2020 that may be closed by this pull request
Images always sent original size #1333
Closed
bmarty
bmarty approved these changes Jun 25, 2020
View reviewed changes
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@onurays onurays changed the title Compress images before sending (for devices below Android 10). Compress images before sending Jun 25, 2020
bmarty
bmarty reviewed Jun 26, 2020
View reviewed changes
Copy link
Member

@bmarty bmarty left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One remark. Also maybe you could squash the commit to make a better git history

...droid/src/main/java/im/vector/matrix/android/internal/session/content/UploadContentWorker.kt Show resolved Hide resolved
bmarty
bmarty approved these changes Jun 26, 2020
View reviewed changes
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the comment

@onurays onurays merged commit 90804f7 into develop Jun 26, 2020
@onurays onurays deleted the feature/fix_compress_images branch June 26, 2020 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmarty bmarty bmarty approved these changes

Assignees

@onurays onurays

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Images always sent original size
2 participants
@onurays @bmarty